Skip to content

Support h4, h5, and h6 #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 23, 2025
Merged

Conversation

DrewJohnsonGT
Copy link
Contributor

@DrewJohnsonGT DrewJohnsonGT commented Apr 23, 2025

Related issue 1158

image

Screen.Recording.2025-04-23.at.1.56.28.PM.mov

Figure it doesn't make sense to add these as default/suggested blocks but adding general support will satisfy a lot of use cases

First contribution here, so let me know if I missed anything!

Re-opened with H6 as well per #1623 (comment)

Copy link

vercel bot commented Apr 23, 2025

@DrewJohnsonGT is attempting to deploy a commit to the TypeCell Team on Vercel.

A member of the Team first needs to authorize it.

@DrewJohnsonGT
Copy link
Contributor Author

@YousefED @nperez0111 is there anything else I should do here?
I know y'all are swamped, but any feedback would be really appreciated

@nperez0111
Copy link
Contributor

Sorry for taking so long on this. Yea, this is mostly good, the one thing we would need to finish this up would be support in the export formats (e.g. PDF, ODT)

@DrewJohnsonGT
Copy link
Contributor Author

DrewJohnsonGT commented May 20, 2025

@nperez0111 No worries! Took a quick stab at that just now
PDF is solid
image

ODT and Word defaults are alright I think?
ODT
image

Word
image

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me

@DrewJohnsonGT DrewJohnsonGT requested a review from nperez0111 May 23, 2025 01:03
@YousefED
Copy link
Collaborator

Nice! @nperez0111 need anything to get this merged? I think it might make sense to make the heading levels configurable? (e.g. simpler Notion style apps might have no need for some levels?)

@hylin
Copy link

hylin commented Jun 16, 2025

Any updates?

@nperez0111
Copy link
Contributor

Sorry, I'm waiting for the toggle blocks to settle before trying to integrate this in.

For full transparency, I will also probably make this configurable, and have the defaults set to just 3 heading levels like it was before this change.

Copy link

vercel bot commented Jun 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote-website ❌ Failed (Inspect) Jun 23, 2025 0:20am

Copy link

pkg-pr-new bot commented Jun 23, 2025

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/ariakit@1634

@blocknote/code-block

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/code-block@1634

@blocknote/core

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/core@1634

@blocknote/mantine

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/mantine@1634

@blocknote/react

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/react@1634

@blocknote/server-util

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/server-util@1634

@blocknote/shadcn

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/shadcn@1634

@blocknote/xl-ai

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-ai@1634

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-docx-exporter@1634

@blocknote/xl-multi-column

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-multi-column@1634

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-odt-exporter@1634

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/TypeCellOS/BlockNote/@blocknote/xl-pdf-exporter@1634

commit: f4d5a80

@nperez0111 nperez0111 merged commit 5adf609 into TypeCellOS:main Jun 23, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants